Re: [PATCH v2] Test t5560: Fix test when run with dash

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 16, 2010, 01:05 UTC
Message-ID: <7v4ommoo4p.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201001152017.00121.j6t@kdbg.org>

Johannes Sixt <j6t@kdbg.org> writes:

Show 7 quoted lines

>> Yesterday, I saw rebase--interactive has a few codepaths where "output"
>> shell function was used with the single-shot export; perhaps they need to
>> also be fixed.
>
> I knew these spots, and they were discussed when that code was introduced. 
> Before I sent out the mail you were responding to, I tried various ways to 
> show the failure in rebase--interactive, but it didn't fail...

It may be the case that the single-shot-ness of these GIT_AUTHOR_NAME exports do not matter at all in that program, even though the original versions may have been written carefully not to leak the value suitable for the current commit to later rounds.

I think the recent updates from Michael actually depends on the distinction not to matter. For example, do_with_author() in 7756ecf (rebase -i: Extract function do_with_author, 2010-01-14) invokes "$@" that could be a shell function.