git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Test t5560: Fix test when run with dash

From
Johannes Sixt <j.sixt@viscovery.net>
Date
Jan 15, 2010, 08:30 UTC
Message-ID
<4B5027B8.2090507@viscovery.net>
In-Reply-To
<1263537842-5792-1-git-send-email-tarmigan+git@gmail.com>
Tarmigan Casebolt schrieb:
>         REQUEST_METHOD="GET" some_shell_function
> I can't tell from my reading of the POSIX spec whether my usage was
> wrong or if dash is wrong,

According to POSIX, variables set as shown above for shell functions are not exported and retain their value after the function returns. I would not be surprised if dash got this right, and the tests fail because they were written for bash, which gets it wrong.

In particular,

f() { sh -c 'echo +$v+'; } v=x f echo +$v+ sh -c 'echo +$v+'"

Should print

++ +x+ ++

I can test only ash, bash, zsh, and ksh, of which only ksh gets it right.
-- Hannes
Previous: Tarmigan CaseboltNext: Junio C Hamano
Message 26 of 31 in “Smart-http tests: Break test t5560-http-backend into pieces”
  1. 1/2 Smart-http tests: Break test t5560-http-backend into piecesTarmigan Casebolt, Dec 28, 2009
  2. 2/2 Smart-http tests: Test http-backend without curl or a webserverTarmigan Casebolt, Dec 28, 2009
  3. Junio C HamanoDec 30, 2009
  4. TarmiganDec 30, 2009
  5. 1/2 Smart-http tests: Break test t5560-http-backend into piecesTarmigan Casebolt, Dec 30, 2009
  6. 2/2 Smart-http tests: Test http-backend without curl or a webserverTarmigan Casebolt, Dec 30, 2009
  7. Junio C HamanoJan 1, 2010
  8. TarmiganJan 2, 2010
  9. 1/3 Smart-http tests: Improve coverage in test t5560Tarmigan Casebolt, Jan 2, 2010
  10. Shawn O. PearceJan 2, 2010
  11. 2/3 Smart-http tests: Break test t5560-http-backend into piecesTarmigan Casebolt, Jan 2, 2010
  12. Shawn O. PearceJan 2, 2010
  13. 1/3 Smart-http tests: Improve coverage in test t5560Tarmigan Casebolt, Jan 2, 2010
  14. 2/3 Smart-http tests: Break test t5560-http-backend into piecesTarmigan Casebolt, Jan 2, 2010
  15. 3/3 Smart-http tests: Test http-backend without curl or a webserverTarmigan Casebolt, Jan 2, 2010
  16. 3/3 Smart-http tests: Test http-backend without curl or a webserverTarmigan Casebolt, Jan 2, 2010
  17. Shawn O. PearceJan 2, 2010
  18. TarmiganJan 2, 2010
  19. Shawn O. PearceJan 2, 2010
  20. 3/3 Smart-http tests: Test http-backend without curl or a webserverTarmigan Casebolt, Jan 2, 2010
  21. Michael HaggertyJan 14, 2010
  22. Test t5560: Fix test when run with dashTarmigan Casebolt, Jan 14, 2010
  23. Michael HaggertyJan 14, 2010
  24. Junio C HamanoJan 14, 2010
  25. Test t5560: Fix test when run with dashTarmigan Casebolt, Jan 15, 2010
  26. Johannes SixtJan 15, 2010
  27. Junio C HamanoJan 15, 2010
  28. Johannes SixtJan 15, 2010
  29. Junio C HamanoJan 15, 2010
  30. Junio C HamanoJan 16, 2010
  31. Michael HaggertyJan 21, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.