git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH RFC 2/2] Smart-http tests: Test http-backend without curl or a webserver

From
TCTarmigan Casebolt <tarmigan+git@gmail.com>
Date
Dec 28, 2009, 22:04 UTC
Message-ID
<1262037899-16786-2-git-send-email-tarmigan+git@gmail.com>
In-Reply-To
<1262037899-16786-1-git-send-email-tarmigan+git@gmail.com>

This reuses many of the tests from t5560 but runs those tests without curl or a webserver. This will hopefully increase the testing coverage for http-backend because it does not require users to set GIT_TEST_HTTPD.

Signed-off-by: Tarmigan Casebolt <tarmigan+git@gmail.com>
---
 t/t5561-http-backend-noserver.sh |   45 ++++++++++++++++++++++----------------
 1 files changed, 26 insertions(+), 19 deletions(-)
diff --git a/t/t5561-http-backend-noserver.sh b/t/t5561-http-backend-noserver.sh
index 501b328..6371e97 100755
--- a/t/t5561-http-backend-noserver.sh
+++ b/t/t5561-http-backend-noserver.sh
@@ -5,12 +5,35 @@ test_description='test git-http-backend-noserver'
 
 HTTPD_DOCUMENT_ROOT_PATH="$TRASH_DIRECTORY"
 
+run_backend() {
+        echo "$3"| \
+        QUERY_STRING="${2#*\?}" \
+	GIT_PROJECT_ROOT="$HTTPD_DOCUMENT_ROOT_PATH" \
+	PATH_INFO="${2%%\?*}" \
+	git http-backend >act.out 2>act.err
+}
+
 GET() {
-    return 0
+    REQUEST_METHOD="GET" \
+    run_backend 0 "/repo.git/$1" &&
+    grep "Status" act.out >act
+    if [ $? -ne 1 ];
+    then
+	printf "Status: $2\r\n" > exp &&
+	test_cmp exp act
+    fi
 }
 
 POST() {
-    return 0
+    REQUEST_METHOD="POST" \
+    CONTENT_TYPE="application/x-$1-request" \
+    run_backend 0 "/repo.git/$1" "$2" &&
+    grep "Status" act.out >act
+    if [ $? -ne 1 ];
+    then
+	printf "Status: $3\r\n" > exp &&
+	test_cmp exp act
+    fi
 }
 
 logdiv() {
@@ -19,26 +42,10 @@ logdiv() {
 
 . "$TEST_DIRECTORY"/t556x_common
 
-run_backend() {
-	REQUEST_METHOD=GET \
-	GIT_PROJECT_ROOT="$HTTPD_DOCUMENT_ROOT_PATH" \
-	PATH_INFO="$2" \
-	git http-backend >act.out 2>act.err
-}
-
-path_info() {
-	if test $1 = 0; then
-		run_backend "$2"
-	else
-		test_must_fail run_backend "$2" &&
-		echo "fatal: '$2': aliased" >exp.err &&
-		test_cmp exp.err act.err
-	fi
-}
-
 test_expect_success 'http-backend blocks bad PATH_INFO' '
 	config http.getanyfile true &&
 
+	REQUEST_METHOD="GET" &&
 	run_backend 0 /repo.git/HEAD &&
 
 	run_backend 1 /repo.git/../HEAD &&
-- 
1.6.6.62.g67314
Previous: Tarmigan CaseboltNext: Junio C Hamano
Message 2 of 31 in “Smart-http tests: Break test t5560-http-backend into pieces”
  1. 1/2 Smart-http tests: Break test t5560-http-backend into piecesTarmigan Casebolt, Dec 28, 2009
  2. 2/2 Smart-http tests: Test http-backend without curl or a webserverTarmigan Casebolt, Dec 28, 2009
  3. Junio C HamanoDec 30, 2009
  4. TarmiganDec 30, 2009
  5. 1/2 Smart-http tests: Break test t5560-http-backend into piecesTarmigan Casebolt, Dec 30, 2009
  6. 2/2 Smart-http tests: Test http-backend without curl or a webserverTarmigan Casebolt, Dec 30, 2009
  7. Junio C HamanoJan 1, 2010
  8. TarmiganJan 2, 2010
  9. 1/3 Smart-http tests: Improve coverage in test t5560Tarmigan Casebolt, Jan 2, 2010
  10. Shawn O. PearceJan 2, 2010
  11. 2/3 Smart-http tests: Break test t5560-http-backend into piecesTarmigan Casebolt, Jan 2, 2010
  12. Shawn O. PearceJan 2, 2010
  13. 1/3 Smart-http tests: Improve coverage in test t5560Tarmigan Casebolt, Jan 2, 2010
  14. 2/3 Smart-http tests: Break test t5560-http-backend into piecesTarmigan Casebolt, Jan 2, 2010
  15. 3/3 Smart-http tests: Test http-backend without curl or a webserverTarmigan Casebolt, Jan 2, 2010
  16. 3/3 Smart-http tests: Test http-backend without curl or a webserverTarmigan Casebolt, Jan 2, 2010
  17. Shawn O. PearceJan 2, 2010
  18. TarmiganJan 2, 2010
  19. Shawn O. PearceJan 2, 2010
  20. 3/3 Smart-http tests: Test http-backend without curl or a webserverTarmigan Casebolt, Jan 2, 2010
  21. Michael HaggertyJan 14, 2010
  22. Test t5560: Fix test when run with dashTarmigan Casebolt, Jan 14, 2010
  23. Michael HaggertyJan 14, 2010
  24. Junio C HamanoJan 14, 2010
  25. Test t5560: Fix test when run with dashTarmigan Casebolt, Jan 15, 2010
  26. Johannes SixtJan 15, 2010
  27. Junio C HamanoJan 15, 2010
  28. Johannes SixtJan 15, 2010
  29. Junio C HamanoJan 15, 2010
  30. Junio C HamanoJan 16, 2010
  31. Michael HaggertyJan 21, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.