git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] Honor $(prefix) set in config.mak* when defining ETC_GIT* and sysconfdir

From
Junio C Hamano <gitster@pobox.com>
Date
May 4, 2011, 18:21 UTC
Message-ID
<7v4o5afht7.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4DC1653A.7000000@viscovery.net>
Johannes Sixt <j.sixt@viscovery.net> writes:
> Junio's worries should not be discarded lightly. But in this case they are
> unfounded.

I appreciate the analysis and explanation. As you can see from the exchange, I was only basing my suggestion on the comments left in the Makefile by you when you did the "relocatable installation" topic.

> So, I don't think that sysconfdir must survive. It was always only a
> helper variable to shorten the code.

My remaining worry was if ./configure users accidentally relied on this internal use of a variable whose name happens to be sysconfdir. If so,

    $ ./configure --sysconfdir=/some/where

may give them a different result once we get rid of sysconfdir from our Makefile.

But I notice that we do not say that sysconfdir is to be replaced in config.mak.in we ship, so such a command line option would have been silently discarded anyway. IOW, no ./configure user would have relied on what our build procedure does.

BUT.

The vanilla Makefile users might have. Among those who install with prefix=$HOME/git, there may be people who do not want to use $HOME/git/etc and an obvious way to do so is by setting sysconfdir to $HOME/etc (an alternative would be to set both ETC_GITCONFIG and ETC_GITATTRIBUTES).

So I think it would probably be a less-impact and useful solution to keep sysconfdir and add "sysconfdir = @sysconfdir@" to config.mak.in as well.

Is Kacper's latest patch with an obvious one-liner to config.mak.in sufficient to achieve that?

  From: Kacper Kornet <kornet@camk.edu.pl>
  Subject: Re: [PATCH 1/1] Honor $(prefix) set in config.mak* when defin...
  Date: Wed, 4 May 2011 16:29:21 +0200
  Message-ID: <20110504142921.GE18585@camk.edu.pl>
Previous: Johannes SixtNext: Junio C Hamano
Message 13 of 26 in “Respect definition of prefix from autotools in ETC_GITCONFIG and ETC_GITATTRIBUTES”
  1. Respect definition of prefix from autotools in ETC_GITCONFIG and ETC_GITATTRIBUTESKacper Kornet, Apr 28, 2011
  2. Junio C HamanoApr 28, 2011
  3. Kacper KornetApr 28, 2011
  4. 1/1 Honor $(prefix) set in config.mak* when defining ETC_GIT* and sysconfdirKacper Kornet, Apr 28, 2011
  5. Honor sysconfdir when set as an configure optionKacper Kornet, Apr 28, 2011
  6. Junio C HamanoApr 28, 2011
  7. Kacper KornetApr 28, 2011
  8. Johannes SixtMay 3, 2011
  9. Junio C HamanoMay 3, 2011
  10. Johannes SixtMay 4, 2011
  11. Kacper KornetMay 4, 2011
  12. Johannes SixtMay 4, 2011
  13. Junio C HamanoMay 4, 2011
  14. Junio C HamanoMay 5, 2011
  15. Johannes SixtMay 5, 2011
  16. Junio C HamanoMay 5, 2011
  17. Johannes SixtMay 6, 2011
  18. Kacper KornetMay 5, 2011
  19. Johannes SixtMay 5, 2011
  20. Kacper KornetMay 5, 2011
  21. Junio C HamanoMay 5, 2011
  22. Johannes SixtMay 9, 2011
  23. Kacper KornetMay 9, 2011
  24. Kacper KornetMay 27, 2011
  25. Kacper KornetMay 5, 2011
  26. Kacper KornetMay 4, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.