Re: [PATCH 1/1] Honor $(prefix) set in config.mak* when defining ETC_GIT* and sysconfdir

From: Kacper Kornet <kornet@camk.edu.pl>
Date: May 5, 2011, 14:29 UTC
Message-ID: <20110505142910.GA31229@camk.edu.pl>
In-Reply-To: <7vwri5c27e.fsf@alter.siamese.dyndns.org>

On Wed, May 04, 2011 at 07:26:29PM -0700, Junio C Hamano wrote:

> Junio C Hamano <gitster@pobox.com> writes:

> > So I think it would probably be a less-impact and useful solution to keep
> > sysconfdir and add "sysconfdir = @sysconfdir@" to config.mak.in as well.

> > Is Kacper's latest patch with an obvious one-liner to config.mak.in
> > sufficient to achieve that?

> >   From: Kacper Kornet <kornet@camk.edu.pl>
> >   Subject: Re: [PATCH 1/1] Honor $(prefix) set in config.mak* when defin...
> >   Date: Wed, 4 May 2011 16:29:21 +0200
> >   Message-ID: <20110504142921.GE18585@camk.edu.pl>

> In other words, this one on top of the above (which defaults sysconfdir
> to /etc when $(prefix) is /usr and then sets git_etcdir to $(sysconfdir)).

There is one more problem with this. If you call:

 ./configure --prefix=/usr --sysconfdir=/<dir>

sysconfdir and git_etcdir are set to /etc not /<dir>. I admit that it is a rather unusual set of options ./configure, but maybe it should be supported. So maybe I will first describe how it should all work in my opinion and I will wait for comments before I will try to implement it.

1. ./configure --prefix=dir1  and dir1 != /usr

    git_etcdir = etc

2. ./configure --prefix=/usr

    git_etcdir = /etc

3. ./configure --prefix=dir1 --syscondir=dir2 (here dir2 has to be an
absolute path)

    git_etcdir =  dir2

4. make prefix=dir1 and dir1 != /usr

    git_etcdir = etc

5. make prefix=/usr

    git_etcdir = /etc

6. make prefix=dir1 sysconfdir=dir2 (here dir2 can be an absolute or
a relative path)

    git_etcdir = dir2

-- 
  Kacper Kornet