Re: [PATCH 1/1] Honor $(prefix) set in config.mak* when defining ETC_GIT* and sysconfdir

From: Johannes Sixt <j.sixt@viscovery.net>
Date: May 5, 2011, 14:45 UTC
Message-ID: <4DC2B814.5070507@viscovery.net>
In-Reply-To: <20110505142910.GA31229@camk.edu.pl>

A:

Show 12 quoted lines

> 1. ./configure --prefix=dir1  and dir1 != /usr
> 
>     git_etcdir = etc
> 
> 2. ./configure --prefix=/usr
> 
>     git_etcdir = /etc
> 
> 3. ./configure --prefix=dir1 --syscondir=dir2 (here dir2 has to be an
> absolute path)
> 
>     git_etcdir =  dir2

Why do you have the restriction that --sysconfdir must be absolute? Is it imposed by autotools?

  4. ./configure --sysconfdir=dir2

     git_etcdir =  dir2

B:

Show 12 quoted lines

> 1. make prefix=dir1 and dir1 != /usr
> 
>     git_etcdir = etc
> 
> 2. make prefix=/usr
> 
>     git_etcdir = /etc
> 
> 3. make prefix=dir1 sysconfdir=dir2 (here dir2 can be an absolute or
> a relative path)
> 
>     git_etcdir = dir2

  4. make sysconfdir=dir2

      git_etcdir = dir2

C: in config.mak write none, one, or both of

  prefix=dir1
  sysconfdir=dir2

with the same 4 case distinctions and corresponding desired results as in B.

Looks fine and simple to implement, except that I don't see that you have to introduce git_etcdir; can't you just stick with the name "sysconfdir"?

-- Hannes