git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t: Replace 'perl' by $PERL_PATH

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 12, 2012, 14:56 UTC
Message-ID
<7v4nqg4lzb.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20120612123454.GA25407@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 8 quoted lines
>> I personally do not mind if we do this consistently, but I am not
>> sure your $PERL_PATH that is not quoted is the right way to invoke
>> it; look for PERL_PATH in t/ to see the existing uses.
>
> My biggest concern is placing an extra portability burden on
> test-writers (who will inevitably forget, and won't notice because what
> they are doing is only broken on obscure systems). Is there a way we can
> hide this behind a perl() shell function or something?

I am hoping that writing 'perl' without any adornment will hopefully stand out like a sore thumb if all perl invocations in existing code are spelled '"$PERL_PATH"'. We forbid "! git cmd" and tell people to write "test_must_fail git cmd" instead, and I think it has worked reasonably well.

Previous: Jeff KingNext: Jeff King
Message 4 of 15 in “t: Replace 'perl' by $PERL_PATH”
  1. t: Replace 'perl' by $PERL_PATHvfr@lyx.org, Jun 11, 2012
  2. Junio C HamanoJun 11, 2012
  3. Jeff KingJun 12, 2012
  4. Junio C HamanoJun 12, 2012
  5. Jeff KingJun 12, 2012
  6. Erik Faye-LundJun 12, 2012
  7. Junio C HamanoJun 12, 2012
  8. Junio C HamanoJun 12, 2012
  9. Jeff KingJun 12, 2012
  10. Vincent van RavesteijnJun 12, 2012
  11. Torsten BögershausenJun 17, 2012
  12. Junio C HamanoJun 17, 2012
  13. Torsten BögershausenJun 17, 2012
  14. Junio C HamanoJun 17, 2012
  15. Torsten BögershausenJun 20, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.