Re: [PATCH] t: Replace 'perl' by $PERL_PATH

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 11, 2012, 19:15 UTC
Message-ID: <7v1ull7j9k.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1339441313-5296-1-git-send-email-vfr@lyx.org>

vfr@lyx.org writes:

Show 16 quoted lines

> From: Vincent van Ravesteijn <vfr@lyx.org>
>
> GIT-BUILD-OPTIONS defines PERL_PATH to be used in the test suite. Only a
> few tests already actually use this variable when perl is needed. The
> other test just call 'perl' and it might happen that the wrong perl
> interpreter is used.
>
> This becomes problematic on Windows, when the perl interpreter that is
> compiled and installed on the Windows system is used, because this perl
> interpreter might introduce some unexpected LF->CRLF conversions.
>
> This patch makes sure that $PERL_PATH is used everywhere in the test suite
> and that the correct perl interpreter is used.
>
> Signed-off-by: Vincent van Ravesteijn <vfr@lyx.org>
> ---

There was already this discussion:

    http://thread.gmane.org/gmane.comp.version-control.git/132560/focus=132561

which basically dismissed effort along this line with "If the perl in your PATH is so broken that it can't be used for simple helpers, then you should fix your PATH."

I personally do not mind if we do this consistently, but I am not sure your $PERL_PATH that is not quoted is the right way to invoke it; look for PERL_PATH in t/ to see the existing uses.