From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 12 Jun 2012 14:56:56 GMT
Subject: Re: [PATCH] t: Replace 'perl' by $PERL_PATH
Message-ID: <7v4nqg4lzb.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120612123454.GA25407@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

>> I personally do not mind if we do this consistently, but I am not
>> sure your $PERL_PATH that is not quoted is the right way to invoke
>> it; look for PERL_PATH in t/ to see the existing uses.
>
> My biggest concern is placing an extra portability burden on
> test-writers (who will inevitably forget, and won't notice because what
> they are doing is only broken on obscure systems). Is there a way we can
> hide this behind a perl() shell function or something?

I am hoping that writing 'perl' without any adornment will hopefully
stand out like a sore thumb if all perl invocations in existing code
are spelled '"$PERL_PATH"'.  We forbid "! git cmd" and tell people
to write "test_must_fail git cmd" instead, and I think it has worked
reasonably well.