Re: [PATCH] SubmittingPatches: Document how to request a patch review tag
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 4, 2013, 21:47 UTC
- Message-ID
- <7v4niwtyb5.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1357333116-6971-1-git-send-email-jason.k.holden.swdev@gmail.com>
Jason Holden <jason.k.holden.swdev@gmail.com> writes:
> A very similiar question was asked previously in: > http://thread.gmane.org/gmane.comp.version-control.git/185564/focus=185570
"Reviewed-by" is for those who are familiar with the part of the system being touched to say "I reviewed this patch, it looks good", and Michael indeed was involved in recent updates to the refs.c infrastructure, so as he said in his message "it looks like I should", it was the right thing to do.
I do not think Michael was asking if that was the standard _thing_ to do; I think the question was if there was a standard _way_ (perhaps a tool) to send such a "Reviewed-by:" line.
> This will apply on top of your last tweak to SubmittingPatches > > Please add my reviewed-by to the rest of the patches in this series.
I do not think you "own" anyting in SubmittingPatches document, though; at least not yet.