git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] SubmittingPatches: Document how to request a patch review tag

From
JHJason Holden <jason.k.holden.swdev@gmail.com>
Date
Jan 4, 2013, 20:58 UTC
Message-ID
<1357333116-6971-1-git-send-email-jason.k.holden.swdev@gmail.com>
In-Reply-To
<7vy5gb33f9.fsf@alter.siamese.dyndns.org>

Document the preferred way a developer should request to have their Acked-by/Tested-by/Reviewed-by tag to a patch series under discussion

Signed-off-by: Jason Holden <jason.k.holden.swdev@gmail.com>
---
Junio,
  I was ready to add my Reviewed-by to this patch series, but I wasn't sure if
I should email just you the patch author (to cut down on overall list traffic)
or both you and the list.  If all reviewed-by/acked-by/tested-by traffic 
should go via the email list I think this patch would be helpful, as I 
wasn't quite sure how wide of a distribution list to use for my 
"Reviewed-by" email.

A very similiar question was asked previously in: http://thread.gmane.org/gmane.comp.version-control.git/185564/focus=185570

This will apply on top of your last tweak to SubmittingPatches
Please add my reviewed-by to the rest of the patches in this series.
-Jason
 Documentation/SubmittingPatches | 5 +++++
 1 file changed, 5 insertions(+)
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index f6276ff..80001c9 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -268,6 +268,11 @@ If you like, you can put extra tags at the end:
 4. "Tested-by:" is used to indicate that the person applied the patch
    and found it to have the desired effect.
 
+If you are a reviewer and wish to add your Acked-by/Reviewed-by/Tested-by tag
+to a patch series under discussion (after having reviewed it or tested it
+of course!), reply to the author of the patch series, cc'ing the git mailing
+list.
+
 You can also create your own tag or use one that's in common usage
 such as "Thanks-to:", "Based-on-patch-by:", or "Mentored-by:".
 
-- 
1.8.1.rc3.28.g0ab5d1f
Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 12 in “Update SubmittingPatches”
  1. 0/3 Update SubmittingPatchesJunio C Hamano, Jan 1, 2013
  2. 1/3 SubmittingPatches: who am I and who cares?Junio C Hamano, Jan 1, 2013
  3. 2/3 SubmittingPatches: mention subsystems with dedicated repositoriesJunio C Hamano, Jan 1, 2013
  4. Jason HoldenJan 2, 2013
  5. Junio C HamanoJan 2, 2013
  6. Junio C HamanoJan 2, 2013
  7. SubmittingPatches: Document how to request a patch review tagJason Holden, Jan 4, 2013
  8. Junio C HamanoJan 4, 2013
  9. Michael HaggertyJan 6, 2013
  10. Junio C HamanoJan 6, 2013
  11. 3/3 SubmittingPatches: remove overlong checklistJunio C Hamano, Jan 1, 2013
  12. Jeff KingJan 2, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.