git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] SubmittingPatches: Document how to request a patch review tag

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Jan 6, 2013, 07:32 UTC
Message-ID
<50E92875.6080305@alum.mit.edu>
In-Reply-To
<1357333116-6971-1-git-send-email-jason.k.holden.swdev@gmail.com>
On 01/04/2013 09:58 PM, Jason Holden wrote:
Show 15 quoted lines
> Document the preferred way a developer should request to have their
> Acked-by/Tested-by/Reviewed-by tag to a patch series under discussion
> 
> Signed-off-by: Jason Holden <jason.k.holden.swdev@gmail.com>
> ---
> Junio,
>   I was ready to add my Reviewed-by to this patch series, but I wasn't sure if
> I should email just you the patch author (to cut down on overall list traffic)
> or both you and the list.  If all reviewed-by/acked-by/tested-by traffic 
> should go via the email list I think this patch would be helpful, as I 
> wasn't quite sure how wide of a distribution list to use for my 
> "Reviewed-by" email.
> 
> A very similiar question was asked previously in:
> http://thread.gmane.org/gmane.comp.version-control.git/185564/focus=185570
On 01/04/2013 10:47 PM, Junio C Hamano wrote:
Show 9 quoted lines
> "Reviewed-by" is for those who are familiar with the part of the
> system being touched to say "I reviewed this patch, it looks good",
> and Michael indeed was involved in recent updates to the refs.c
> infrastructure, so as he said in his message "it looks like I should",
> it was the right thing to do.
>
> I do not think Michael was asking if that was the standard _thing_
> to do; I think the question was if there was a standard _way_
> (perhaps a tool) to send such a "Reviewed-by:" line.

Junio is correct; I was just asking whether there was a particular email convention for adding a "Reviewed-by:" line. It would be nice for this to be mentioned in the documentation.

Show 18 quoted lines
>  Documentation/SubmittingPatches | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index f6276ff..80001c9 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -268,6 +268,11 @@ If you like, you can put extra tags at the end:
>  4. "Tested-by:" is used to indicate that the person applied the patch
>     and found it to have the desired effect.
>  
> +If you are a reviewer and wish to add your Acked-by/Reviewed-by/Tested-by tag
> +to a patch series under discussion (after having reviewed it or tested it
> +of course!), reply to the author of the patch series, cc'ing the git mailing
> +list.
> +
>  You can also create your own tag or use one that's in common usage
>  such as "Thanks-to:", "Based-on-patch-by:", or "Mentored-by:".

I don't think this is quite correct. Such emails should be "reply-to-all" people who have participated in the thread, which might include more than just the patch author and the git mailing list.

Michael
-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
Previous: Junio C HamanoNext: Junio C Hamano
Message 9 of 12 in “Update SubmittingPatches”
  1. 0/3 Update SubmittingPatchesJunio C Hamano, Jan 1, 2013
  2. 1/3 SubmittingPatches: who am I and who cares?Junio C Hamano, Jan 1, 2013
  3. 2/3 SubmittingPatches: mention subsystems with dedicated repositoriesJunio C Hamano, Jan 1, 2013
  4. Jason HoldenJan 2, 2013
  5. Junio C HamanoJan 2, 2013
  6. Junio C HamanoJan 2, 2013
  7. SubmittingPatches: Document how to request a patch review tagJason Holden, Jan 4, 2013
  8. Junio C HamanoJan 4, 2013
  9. Michael HaggertyJan 6, 2013
  10. Junio C HamanoJan 6, 2013
  11. 3/3 SubmittingPatches: remove overlong checklistJunio C Hamano, Jan 1, 2013
  12. Jeff KingJan 2, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.