Re: [PATCH 1/6] Allow pack header preprocessing before unpack-objects/index-pack.
- From
Junio C Hamano <junkio@cox.net>
- Date
- Nov 1, 2006, 23:50 UTC
- Message-ID
- <7v3b92zpzj.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <11624187853116-git-send-email-nico@cam.org>
Rather nicely done. I see upto 2/6 are identical to what has sitting in "pu" for the past few days, modulo some indentation?
I wonder how much testing has this series seen, by the way.
Also, I wonder what happens after 5/6 errors out. It dies and the caller (typically receive-pack) reports it back, which would fail the push (and does not update the refs). Retrying in such a case would probably use the same set of refs on both ends, resulting in exactly the same pack...