Re: [PATCH 6/6] remove .keep pack lock files when done with refs update

From: Nicolas Pitre <nico@cam.org>
Date: Nov 2, 2006, 17:25 UTC
Message-ID: <Pine.LNX.4.64.0611021218510.11384@xanadu.home>
In-Reply-To: <Pine.LNX.4.64.0611020959410.11384@xanadu.home>

On Thu, 2 Nov 2006, Nicolas Pitre wrote:

Show 12 quoted lines

> Another area of that patch I'm not really sure of is this:
> 
> @@ -408,6 +415,7 @@ fetch_main () {
>           append_fetch_head "$sha1" "$remote" \
>                   "$remote_name" "$remote_nick" "$local_name" "$not_for_merge"
>        done
> +      if [ "$pack_lockfile" ]; then rm -f "$pack_lockfile"; fi
>      ) || exit ;;
>    esac
> 
> How can I make sure to not clobber a non-zero return code with the rm 
> that would prevent the exit while still performing the rm in all cases?

OK looking at it again I think the || exit is only meant to match the exit 1 before that point. Since this is a subshell then the exit 1 wouldn't exit it all on its own. Otherwise there is no errors expected to trickle out of the while loop and I _think_ the above is correct.

Do you still want a new patch for the micronit quoting issue?