Re: [PATCH] Trim hint printed when gecos is empty.

From: Junio C Hamano <junkio@cox.net>
Date: Nov 28, 2006, 18:29 UTC
Message-ID: <7v3b834e75.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200611281506.53518.andyparkins@gmail.com>

Andy Parkins <andyparkins@gmail.com> writes:

Show 8 quoted lines

> On Tuesday 2006 November 28 14:40, Johannes Schindelin wrote:
>
>> You are probably different than me. What with my track record, I _trust_
>> my patches to be not perfect at all...
>
> ...  I had understood it was a 
> legal tool to trace the provenance of a patch - not to sign off on it being 
> bug free (which surely is impossible).

Johannes, Andy's interpretation is in line with the policy in SubmittingPatches. S-o-b is about warranty of provenance, and not about correctness or cheering (Acked-by).

And I think it makes sense to add "-s" automatically to commits made in a private working repository in which the developer who configured "-s" to be added automatically is the only person who makes commits. As already mentioned in the thread, one of the hooks should be usable for that. And it certainly is a possibility to add a config to turn "-s" on.

But I suspect that it would be cleaner and more useful to teach "git commit" to use a commit message template per repository and put the S-o-b in there -- that mechanism would be usable for things other than just S-o-b lines as projects see fit.