Re: [PATCH] Trim hint printed when gecos is empty.

From: Andy Parkins <andyparkins@gmail.com>
Date: Nov 28, 2006, 15:06 UTC
Message-ID: <200611281506.53518.andyparkins@gmail.com>
In-Reply-To: <Pine.LNX.4.63.0611281536230.30004@wbgn013.biozentrum.uni-wuerzburg.de>

On Tuesday 2006 November 28 14:40, Johannes Schindelin wrote:

> You are probably different than me. What with my track record, I _trust_
> my patches to be not perfect at all. Nevertheless, I commit here and now,
> and usually I regroup the commits into a nice patch (series) (AKA poor
> man's StGit).

I'm certainly not perfect, nor would I ever claim to be. Perhaps I have misunderstood the purpose of the Signed-Off line. I had understood it was a legal tool to trace the provenance of a patch - not to sign off on it being bug free (which surely is impossible).

Since I know that I, and I alone wrote that patch, I can sign off on it regardless of it being any good technically.

This is in agreement with my understanding of the Documentation/SubmittingPatches file included with git.

"The sign-off is a simple line at the end of the explanation for the patch, which certifies that you wrote it or otherwise have the right to pass it on as a open-source patch."

Show 5 quoted lines

> So I will never need something like you suggest. Having said that, if you
> think it is best for you to mark every commit as signed-off-by you, just
> add an alias:
>
> 	git repo-config --global alias.c "commit -s"

That requires that I introduce a new command; I want the existing command to do The Right Thing. Also; I certainly wouldn't want it global, as I said in my original message - this is a per-project choice. Some projects don't have Signed-Off lines, so there is no point there.

Ideally, I'd be able to do
        git repo-config alias.commit "commit -s"
Just as I can with shell commands.

Andy

-- 
Dr Andy Parkins, M Eng (hons), MIEE