Re: [PATCH] Install git-sh-setup.sh into $(prefix)/share/git-core. Call with explicit path.
- From
Junio C Hamano <junkio@cox.net>
- Date
- Dec 8, 2006, 20:45 UTC
- Message-ID
- <7v3b7qi0b4.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <20061208193718.GA11906@soma>
Eric Wong <normalperson@yhbt.net> writes:
Show 8 quoted lines
> Han-Wen Nienhuys <hanwen@xs4all.nl> wrote: >> >> git-sh-setup isn't a 'normal' binary, in that it should be called by >> bash only and not run in a subshell. Therefore, it should not be installed >> in a executable directory, but rather in $prefix/share/git-core/ > > This seems to break existing hooks, or at least old repositories can > be stuck using an old version of git-sh-setup in those hooks.
Honestly speaking, I do not think this patch is worth it. People who care deeply enough should just use gitexecdir that is separate from bindir.