Re: [PATCH] Install git-sh-setup.sh into $(prefix)/share/git-core. Call with explicit path.

From: Han-Wen Nienhuys <hanwen@xs4all.nl>
Date: Dec 9, 2006, 13:08 UTC
Message-ID: <457AB54B.8070107@xs4all.nl>
In-Reply-To: <7v3b7qi0b4.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano escreveu:

Show 12 quoted lines

> Eric Wong <normalperson@yhbt.net> writes:
> 
>> Han-Wen Nienhuys <hanwen@xs4all.nl> wrote:
>>> git-sh-setup isn't a 'normal' binary, in that it should be called by
>>> bash only and not run in a subshell. Therefore, it should not be installed
>>> in a executable directory, but rather in $prefix/share/git-core/
>> This seems to break existing hooks, or at least old repositories can
>> be stuck using an old version of git-sh-setup in those hooks.
> 
> Honestly speaking, I do not think this patch is worth it.
> People who care deeply enough should just use gitexecdir that is
> separate from bindir.

And how about coding the path of git-sh-setup (in <prefix>/bin/git-sh-setup) in the shell scripts? This will ensure that the sh-setup is the one from the right package, but still retain backward compatibility for scripts.