Re: [PATCH] Install git-sh-setup.sh into $(prefix)/share/git-core. Call with explicit path.

From: Han-Wen Nienhuys <hanwen@xs4all.nl>
Date: Dec 9, 2006, 23:40 UTC
Message-ID: <457B4981.2030408@xs4all.nl>
In-Reply-To: <7v1wn8ah2k.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano escreveu:

Show 9 quoted lines

> Han-Wen Nienhuys <hanwen@xs4all.nl> writes:
> 
>> And how about coding the path of git-sh-setup (in <prefix>/bin/git-sh-setup) 
>> in the shell scripts? This will ensure that the sh-setup is the one
>> from the right package, but still retain backward compatibility for 
>> scripts.
> 
> Hardcoding $(bin)/git-sh-setup is a non-starter; it breaks
> GIT_EXEC_PATH convention to allow users to override it.

> In other words, I do not know what real problem you are trying
> to solve.

The real problem is that git is nonstandard to wrap around: scripts like git-sh-setup need special attention, because they don't work with

  exec /some/where/else/git-sh-setup "$@"

I admit is a small problem, but IMO that's not an argument not to solve it.