Re: [PATCH 2/5] sq_quote_argv and add_to_string rework with strbuf's.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 19, 2007, 08:09 UTC
- Message-ID
- <7v3axbqdnw.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20070918224120.1DC44344AB3@madism.org>
Pierre Habouzit <madcoder@debian.org> writes:
Show 26 quoted lines
> * sq_quote_buf is made public, and works on a strbuf.
> * sq_quote_argv also works on a strbuf.
> * make sq_quote_argv take a "maxlen" argument to check the buffer won't grow
> too big.
>
> Signed-off-by: Pierre Habouzit <madcoder@debian.org>
> ---
> connect.c | 21 ++++++--------
> git.c | 16 +++-------
> quote.c | 91 ++++++++++++++++---------------------------------------------
> quote.h | 9 ++----
> rsh.c | 33 ++++++----------------
> trace.c | 35 +++++++-----------------
> 6 files changed, 60 insertions(+), 145 deletions(-)
> ...
> diff --git a/quote.c b/quote.c
> index d88bf75..4df3262 100644
> --- a/quote.c
> +++ b/quote.c
> @@ -20,29 +20,26 @@ static inline int need_bs_quote(char c)
> return (c == '\'' || c == '!');
> }
>
> -static size_t sq_quote_buf(char *dst, size_t n, const char *src)
> +void sq_quote_buf(struct strbuf *dst, const char *src)
> {You got rid of use of EMIT() macro which is local to this function, so you need to remove the #undef/#define in front of the function as well.