Re: [PATCH 4/5] Full rework of quote_c_style and write_name_quoted.
On Wed, Sep 19, 2007 at 12:55:52AM +0000, Junio C Hamano wrote:
Show 12 quoted lines
> Pierre Habouzit <madcoder@debian.org> writes:
>
> > On Tue, Sep 18, 2007 at 10:00:51PM +0000, Pierre Habouzit wrote:
> >> + cp = strchr(qname.buf + qname.len + 3 - max, '/');
> >> + if (cp)
> >> + cp = qname.buf + qname.len + 3 - max;
> >
> > OMG, this is supposed to be if (!cp) of course...
> >
> > I wonder how this passed the testsuite.
>
> You would need a new test, I guess, before a huge rewrite.
OTOH this is in the code that generates the diffstats, it's not _that_
surprising that we don't have extensive tests about that, as it's not
critical in git afaict ;)
--
·O· Pierre Habouzit
··O madcoder@debian.org
OOO http://www.madism.org
Pierre Habouzit <madcoder@debian.org>