Re: [PATCH 4/5] Full rework of quote_c_style and write_name_quoted.
On Wed, Sep 19, 2007 at 08:28:47AM +0000, Junio C Hamano wrote:
Show 7 quoted lines
> At this point, you have max that is larger by 3 than what old
> code had. That would make the next two printf() you added as
> expected. This affects scaling of add/delete code. Is this
> intentional? I _think_ the change is correct (there is no
> reason that name display being cliped should affect the length
> of the bar graph), but that should have been documented as a
> separate bugfix in the commit log.
Indeed, in fact I didn't noticed that difference, I'll document that.
Show 21 quoted lines
>
> > diff --git a/quote.c b/quote.c
> > index 67c6527..a8a755a 100644
> > --- a/quote.c
> > +++ b/quote.c
> > @@ -114,83 +114,142 @@ char *sq_dequote(char *arg)
> > }
> > }
> >
> > +/* 1 means: quote as octal
> > + * 0 means: quote as octal if (quote_path_fully)
> > + * -1 means: never quote
> > + * c: quote as "\\c"
> > + */
> > +#define X8(x) x, x, x, x, x, x, x, x
> > +#define X16(x) X8(x), X8(x)
> > +static signed char const sq_lookup[256] = {
> > + /* 0 1 2 3 4 5 6 7 */
> > + /* 0x00 */ 1, 1, 1, 1, 1, 1, 'a', 1,
>
> Isn't BEL == 0x07, not 0x06?Show 8 quoted lines
> > + /* 0x08 */ 'b', 't', 'n', 'v', 'f', 'r', 1, 1,
> > + /* 0x10 */ X16(1),
> > + /* 0x20 */ -1, -1, '"', -1, -1, -1, -1, -1,
> > + /* 0x28 */ X16(-1), X16(-1), X16(-1),
> > + /* 0x58 */ -1, -1, -1, -1,'\\', -1, -1, -1,
> > + /* 0x60 */ X16(-1), X16(-1),
>
> Shouldn't you quote DEL == 0177 here?
Show 14 quoted lines
> > /*
> > * C-style name quoting.
> > *
> > - * Does one of three things:
> > - *
> > * (1) if outbuf and outfp are both NULL, inspect the input name and
> > * counts the number of bytes that are needed to hold c_style
> > * quoted version of name, counting the double quotes around
> > * it but not terminating NUL, and returns it. However, if name
> > * does not need c_style quoting, it returns 0.
> > *
>
> You need to update this comment; you do not have outbuf nor
> outfp anymore, you have something else.
heh, well outfp is still here, but I'll fix the part about outbuf.
--
·O· Pierre Habouzit
··O madcoder@debian.org
OOO http://www.madism.org
Pierre Habouzit <madcoder@debian.org>