Re: Adding gitweb.owner, last shot

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 8, 2008, 07:38 UTC
Message-ID: <7v3as3lwxn.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1202445714-28971-1-git-send-email-ribas@c3sl.ufpr.br>

Bruno Ribas <ribas@c3sl.ufpr.br> writes:

Show 17 quoted lines

> ... there is no major performance downgrade
> compared to $projects_list , as seen below:
>
> 8<-------
> These times i got with a 1000projects running 2 dd to generate disk IO.
> Here comes the resultm
> NO projects_list  projects_list
> 16m30s69          15m10s74       default gitweb, using FS's owner
> 16m07s40          15m24s34       patched to get gitweb.owner
> 16m37s76          15m59s32       same above, but without gitweb.owner
>
> Now results for a 1000projects on an idle machine.
> NO projects_list  projects_list
> 1m19s08           1m09s55       default gitweb, using FS's owner
> 1m17s58           1m09s55       patched to get gitweb.owner
> 1m18s49           1m08s96       same above, but without gitweb.owner
> 8<-------

Large installations would maintain the project_list in the flat file format for performance reasons anyway. Benchmarking under a condition that yields unreasonably long response time is somewhat meaningless, I am afraid. Who sane would wait for 15 minutes for project list to come up?

So I think your patch makes sense. It would not help nor hurt large installations, and would help smaller installations that do not care much about performance but are more interested in the convenience of not having to worry about maintaining the project_list.

As the act of signing off patches is a legal statement, I'd prefer real person's name, not "Git Managment for C3SL", in the messages to be applied. The change that adds the feature, and the documentation update to describe that new feature, should be in the same single patch for a small change like this.