Re: [PATCH] gitweb: Use the config file to set repository owner's name.
- From
- Bruno Cesar Ribas <ribas@c3sl.ufpr.br>
- Date
- Feb 8, 2008, 16:07 UTC
- Message-ID
- <20080208160757.GA11965@c3sl.ufpr.br>
- In-Reply-To
- <200802081633.55934.jnareb@gmail.com>
On Fri, Feb 08, 2008 at 04:33:54PM +0100, Jakub Narebski wrote:
Show 30 quoted lines
> I have joined the two emails to reply only once.
>
> On Fri, 8 Feb 2008, Bruno Cesar Ribas wrote:
> > On Fri, Feb 08, 2008 at 02:55:33AM -0800, Jakub Narebski wrote:
> >> Bruno Ribas <ribas@c3sl.ufpr.br> writes:
> >>>
> >>> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> >>> index 8ef2735..e8a43b7 100755
> >>> --- a/gitweb/gitweb.perl
> >>> +++ b/gitweb/gitweb.perl
> >>> @@ -1767,7 +1767,12 @@ sub git_get_project_owner {
> >>> if (exists $gitweb_project_owner->{$project}) {
> >>> $owner = $gitweb_project_owner->{$project};
> >>> }
> >>> - if (!defined $owner) {
> >>> +
> >>> + if (!defined $owner){
> >>> + $owner = git_get_project_config('owner');
> >>> + }
> >>> +
> >>> + if (!$owner) {
> >>> $owner = get_file_owner("$projectroot/$project");
> >>> }
>
> Another comment: why did you change from checking of "!defined $owner"
> to checking "!$owner"? git_get_project_config('owner') returns undef
> if gitweb.owner is not defined. With checking for defined we can avoid
> false positives of owner being "0" (in practice I think this does not
> matter) or "" (this could happen if somebody doesn't want for project
> to have owner shown).When I tested it returned empty, but i found out it was lack of NAME for the user i was running tests.
Show 5 quoted lines
> > > > I'll resend [...] with $git_dir set. > > And with signoff corrected, I assume?
of course.
> > Please try to check if the code works with and without gitweb.owner set > before sending new version of the patch...
I always do that.
> -- > Jakub Narebski > Poland
-- Bruno Ribas - ribas@c3sl.ufpr.br http://web.inf.ufpr.br/ribas C3SL: http://www.c3sl.ufpr.br