Re: [PATCH/RFC] ignore unknown color configuration
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 16, 2009, 01:25 UTC
- Message-ID
- <7v3a3bwvzj.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <7vzl5mjndi.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 18 quoted lines
> Jeff King <peff@peff.net> writes: > >> On Sat, Dec 12, 2009 at 01:45:45PM -0800, Junio C Hamano wrote: >> >>> This is a sane thing to do, as "slot" is part of the name of the variable, >>> and we generally do not warn upon seeing a misspelled variable name (it >>> makes it worse that "func" is not even misspelled but merely unknown to >>> older version of git in your scenario). >>> >>> On the other hand, I suspect that most people would apprecfiate if their >>> git pointed out "diff.color.finc? What do you mean?" before they waste >>> 30 minutes wondering why the new feature in 1.6.6 does not work for them. >> >> I would be more sympathetic to that user if this weren't the _only_ set >> of variables with this property. They don't get warned for diff.externel >> or color.show-branch. > > True and fair enough. Let's have this in 1.6.6 then.
Actually I think we should have this in 1.6.5.X as well for it to be useful. Am I mistaken?