Re: [PATCH/RFC] ignore unknown color configuration

From: Jeff King <peff@peff.net>
Date: Dec 12, 2009, 22:20 UTC
Message-ID: <20091212222046.GA25973@coredump.intra.peff.net>
In-Reply-To: <7vzl5nn9x2.fsf@alter.siamese.dyndns.org>

On Sat, Dec 12, 2009 at 01:45:45PM -0800, Junio C Hamano wrote:

Show 8 quoted lines

> This is a sane thing to do, as "slot" is part of the name of the variable,
> and we generally do not warn upon seeing a misspelled variable name (it
> makes it worse that "func" is not even misspelled but merely unknown to
> older version of git in your scenario).
> 
> On the other hand, I suspect that most people would apprecfiate if their
> git pointed out "diff.color.finc?  What do you mean?"  before they waste
> 30 minutes wondering why the new feature in 1.6.6 does not work for them.

I would be more sympathetic to that user if this weren't the _only_ set of variables with this property. They don't get warned for diff.externel or color.show-branch.

If we are going to declare subsets of the namespace as "complete" (and warn about unknown keys in them), then we should probably be more thorough about it (but I don't personally think that is a good idea, as version portability is IMHO more useful).

-Peff