Re: [PATCH/RFC] ignore unknown color configuration

From: Jeff King <peff@peff.net>
Date: Dec 16, 2009, 03:45 UTC
Message-ID: <20091216034529.GA9742@sigill.intra.peff.net>
In-Reply-To: <7v3a3bwvzj.fsf@alter.siamese.dyndns.org>

On Tue, Dec 15, 2009 at 05:25:36PM -0800, Junio C Hamano wrote:

Show 8 quoted lines

> >> I would be more sympathetic to that user if this weren't the _only_ set
> >> of variables with this property. They don't get warned for diff.externel
> >> or color.show-branch.
> >
> > True and fair enough.  Let's have this in 1.6.6 then.
> 
> Actually I think we should have this in 1.6.5.X as well for it to be
> useful.  Am I mistaken?

The earlier the better for making it useful, but it is still somewhat of a lost cause for color.diff.func. The problem comes from using git v1.6.6, setting the variable, and then going to back to some older version (either because you are testing multiple versions, or because your config is shared across multiple machines).

So yes, putting it in v1.6.5.x means switching back there will not be as painful. But switching back to existing versions will still be broken until all older versions you might want to switch to have this patch.

So we are not so much fixing this color.diff.func problem as future-proofing against this happening again.

-Peff