git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] base85: No need to initialize the decode table in encode_85

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 8, 2010, 15:55 UTC
Message-ID
<7v3a2giobm.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4B475361.60506@drmicha.warpmail.net>
Michael J Gruber <git@drmicha.warpmail.net> writes:
Show 8 quoted lines
> Andreas Gruenbacher venit, vidit, dixit 08.01.2010 14:39:
>> Signed-off-by: Andreas Gruenbacher <agruen@suse.de>
>> ---
>
> For the less informed it may be worthwhile to have an explanation in the
> commit message why encode_85() does not need to initialize the table. (I
> strongly suspect it's a matter of de vs. en, i.e. "because it only
> encodes but does not decode."...)
The title can be reworded to
    base85: encode85() does not use the decode table
Previous: Michael J GruberNext: Andreas Gruenbacher
Message 7 of 11 in “base85: Two tiny fixes”
  1. Andreas GruenbacherJan 7, 2010
  2. Nicolas PitreJan 7, 2010
  3. Andreas GruenbacherJan 8, 2010
  4. 1/3 base85 debug code: Fix length byte calculationAndreas Gruenbacher, Jan 8, 2010
  5. 2/3 base85: No need to initialize the decode table in encode_85Andreas Gruenbacher, Jan 8, 2010
  6. Michael J GruberJan 8, 2010
  7. Junio C HamanoJan 8, 2010
  8. base85: encode85() does not use the decode tableAndreas Gruenbacher, Jan 8, 2010
  9. base85: encode_85() does not use the decode tableAndreas Gruenbacher, Jan 8, 2010
  10. 3/3 base85: Make the code more obvious instead of explaining the non-obviousAndreas Gruenbacher, Jan 8, 2010
  11. A Large Angry SCMJan 8, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.