Re: [PATCH 2/3] base85: No need to initialize the decode table in encode_85

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Jan 8, 2010, 15:46 UTC
Message-ID: <4B475361.60506@drmicha.warpmail.net>
In-Reply-To: <1262958000-27181-2-git-send-email-agruen@suse.de>

Andreas Gruenbacher venit, vidit, dixit 08.01.2010 14:39:

> Signed-off-by: Andreas Gruenbacher <agruen@suse.de>
> ---

For the less informed it may be worthwhile to have an explanation in the commit message why encode_85() does not need to initialize the table. (I strongly suspect it's a matter of de vs. en, i.e. "because it only encodes but does not decode."...)

Show 16 quoted lines

>  base85.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/base85.c b/base85.c
> index 1d165d9..7204ce2 100644
> --- a/base85.c
> +++ b/base85.c
> @@ -84,8 +84,6 @@ int decode_85(char *dst, const char *buffer, int len)
>  
>  void encode_85(char *buf, const unsigned char *data, int bytes)
>  {
> -	prep_base85();
> -
>  	say("encode 85");
>  	while (bytes) {
>  		unsigned acc = 0;