git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] Restructure some of the checkout opts.

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 6, 2010, 06:25 UTC
Message-ID
<7v39tnwfqk.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4C838BE9.5000006@web.de>
Jens Lehmann <Jens.Lehmann@web.de> writes:
Show 8 quoted lines
> Am 05.09.2010 14:09, schrieb Jared Hance:
>> Previously, most opts in `builtin.checkout.c' had been an instance of
>> `struct checkout_opts'. It appears that some of the opts that were
>> perhaps added later were not in the struct. Move them into the struct
>> in order to maintain consistency.
>
> Hm, they aren't used outside of cmd_checkout() (as the other members
> are), so maybe it is ok that they aren't in the struct?

Correct. I do not think they are outside the structure because they are overlooked.

They simply do not make sense outside the context of "builtin/checkout.c" where "struct checkout" is used (e.g. what would patch-mode possibly mean in the context of "builtin/apply" where the struct is used to check out a path that is not checked out to the working tree). Moving them into the structure would thus make no sense and _will_ confuse people.

Previous: Jared Hance
Message 4 of 4 in “Restructure some of the checkout opts.”
  1. Restructure some of the checkout opts.Jared Hance, Sep 5, 2010
  2. Jens LehmannSep 5, 2010
  3. Jared HanceSep 5, 2010
  4. Junio C HamanoSep 6, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.