git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] Restructure some of the checkout opts.

From
Jared Hance <jaredhance@gmail.com>
Date
Sep 5, 2010, 12:54 UTC
Message-ID
<20100905125414.GA3230@localhost.localdomain>
In-Reply-To
<4C838BE9.5000006@web.de>
On Sun, Sep 05, 2010 at 02:24:09PM +0200, Jens Lehmann wrote:
Show 8 quoted lines
> Am 05.09.2010 14:09, schrieb Jared Hance:
> > Previously, most opts in `builtin.checkout.c' had been an instance of
> > `struct checkout_opts'. It appears that some of the opts that were
> > perhaps added later were not in the struct. Move them into the struct
> > in order to maintain consistency.
> 
> Hm, they aren't used outside of cmd_checkout() (as the other members
> are), so maybe it is ok that they aren't in the struct?

I guessed that this was the reason that they were overlooked, but it seemed a little odd that every other opt was stored in the struct and it just seemed to be more consistent to have _everything_ in the struct.

It also makes it more clear that they opts, whereas before, you might think they weren't at a first glance because they weren't in the struct like the others.

I'll leave this to you guys to decide what to do with it.
Previous: Jens LehmannNext: Junio C Hamano
Message 3 of 4 in “Restructure some of the checkout opts.”
  1. Restructure some of the checkout opts.Jared Hance, Sep 5, 2010
  2. Jens LehmannSep 5, 2010
  3. Jared HanceSep 5, 2010
  4. Junio C HamanoSep 6, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.