From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 06 Sep 2010 06:25:23 GMT
Subject: Re: [PATCH/RFC] Restructure some of the checkout opts.
Message-ID: <7v39tnwfqk.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4C838BE9.5000006@web.de>

Jens Lehmann <Jens.Lehmann@web.de> writes:

> Am 05.09.2010 14:09, schrieb Jared Hance:
>> Previously, most opts in `builtin.checkout.c' had been an instance of
>> `struct checkout_opts'. It appears that some of the opts that were
>> perhaps added later were not in the struct. Move them into the struct
>> in order to maintain consistency.
>
> Hm, they aren't used outside of cmd_checkout() (as the other members
> are), so maybe it is ok that they aren't in the struct?

Correct.  I do not think they are outside the structure because they are
overlooked.

They simply do not make sense outside the context of "builtin/checkout.c"
where "struct checkout" is used (e.g. what would patch-mode possibly mean
in the context of "builtin/apply" where the struct is used to check out a
path that is not checked out to the working tree).  Moving them into the
structure would thus make no sense and _will_ confuse people.