git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv2] gitweb: Use GITWEB_CONFIG_SYSTEM even if GITWEB_CONFIG does exist

From
Junio C Hamano <gitster@pobox.com>
Date
May 17, 2011, 05:32 UTC
Message-ID
<7v39kdj3hw.fsf@alter.siamese.dyndns.org>
In-Reply-To
<201105161153.24382.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> writes:
Show 5 quoted lines
> This commit changes gitweb behavior so that configuration in
> per-instance configuration file can _override_ settings from
> system-wide configuration file.
>
> Note that strictly speaking it is backwards incompatible change.

I am not sure if we gain enough from this change. As the system-wide one can be arbitrarily overriden by per-instance one, the goal of this change cannot be to make sure that the system administrator can enforce the system wide policy over all the gitweb instances.

I think the goal is to let per-instance configuration have an easy way to inherit from a common sane default, but if that is the case, wouldn't it be a lot safer and more backward compatible way to just instruct people to include that common default configuration at the beginning of per-instance configuration file instead? After all, you would need to give some advice like this ...

> Check your resulting gitweb configuration, please.
... either way.
Previous: Jakub NarebskiNext: Drew Northup
Message 5 of 8 in “gitweb: Use GITWEB_CONFIG_SYSTEM even if GITWEB_CONFIG does exist”
  1. gitweb: Use GITWEB_CONFIG_SYSTEM even if GITWEB_CONFIG does existJakub Narebski, May 14, 2011
  2. Jonathan NiederMay 14, 2011
  3. Jakub NarebskiMay 15, 2011
  4. [PATCHv2] gitweb: Use GITWEB_CONFIG_SYSTEM even if GITWEB_CONFIG does existJakub Narebski, May 16, 2011
  5. Junio C HamanoMay 17, 2011
  6. Drew NorthupMay 17, 2011
  7. Junio C HamanoMay 17, 2011
  8. Drew NorthupMay 16, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.