Re: [PATCH] gitweb: Use GITWEB_CONFIG_SYSTEM even if GITWEB_CONFIG does exist

From: Drew Northup <drew.northup@maine.edu>
Date: May 16, 2011, 12:10 UTC
Message-ID: <1305547838.3396.4.camel@drew-northup.unet.maine.edu>
In-Reply-To: <201105151153.08826.jnareb@gmail.com>

On Sun, 2011-05-15 at 11:53 +0200, Jakub Narebski wrote:

Show 20 quoted lines

> On Sat, 14 May 2011, Jonathan Nieder wrote:
> > Jakub Narebski wrote:
> > 
> > > If per-instance configuration file exists, then system-wide
> > > configuration was _not used at all_.  This is quite untypical and
> > > suprising behavior.
> > 
> > I agree.  How to avoid breaking existing installations, though?  (I'm
> > especially worried because distro packages tend to ship their own
> > /etc/gitweb.conf, so the admin might not even know about what's
> > there.)  For example, depending on the content of /etc/gitweb.conf,
> > this has the potential to break "git instaweb".
> 
> I don't think that this change has potential to break "git instaweb",
> because "git instaweb" creates its own gitweb_conf.perl - settings
> there would override distro's /etc/gitweb.conf.  But I have not checked
> if it doesn't rely on some values being default; it shouldn't though.
> 
> It is a PITA to have to retain backward compatibility with our bugs
> and mistakes.  Perhaps this change is for 1.8.0 version boundary, then?

I'm comfortable putting this at the 1.8.0 boundary. Frankly, I think that the default /etc/gitweb.conf should be a file full of commented-out examples anyway. I do believe that at least one distro is doing that already. Doing so decreases the potential pain for those still expecting the old behavior.

-- 
-Drew Northup
________________________________________________
"As opposed to vegetable or mineral error?"
-John Pescatore, SANS NewsBites Vol. 12 Num. 59