From: Junio C Hamano Date: Tue, 17 May 2011 05:32:59 GMT Subject: Re: [PATCHv2] gitweb: Use GITWEB_CONFIG_SYSTEM even if GITWEB_CONFIG does exist Message-ID: <7v39kdj3hw.fsf@alter.siamese.dyndns.org> In-Reply-To: <201105161153.24382.jnareb@gmail.com> Jakub Narebski writes: > This commit changes gitweb behavior so that configuration in > per-instance configuration file can _override_ settings from > system-wide configuration file. > > Note that strictly speaking it is backwards incompatible change. I am not sure if we gain enough from this change. As the system-wide one can be arbitrarily overriden by per-instance one, the goal of this change cannot be to make sure that the system administrator can enforce the system wide policy over all the gitweb instances. I think the goal is to let per-instance configuration have an easy way to inherit from a common sane default, but if that is the case, wouldn't it be a lot safer and more backward compatible way to just instruct people to include that common default configuration at the beginning of per-instance configuration file instead? After all, you would need to give some advice like this ... > Check your resulting gitweb configuration, please. ... either way.