Re: [PATCH 4/2] Fix parent rewriting in --early-output
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 13, 2007, 08:48 UTC
- Message-ID
- <7v1wauv8dr.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <alpine.LFD.0.9999.0711122309270.2786@woody.linux-foundation.org>
Linus Torvalds <torvalds@linux-foundation.org> writes:
Show 10 quoted lines
> This solves the problem quite naturally, because any tree that hasn't been > parsed - or even if it *has* been parsed, but just hasn't gone through > the compare function - will then always be seen as "different" and thus > interesting. > > This fairly straight-forward patch seems to work. It *replaces* the > pervious "patch 4/2", and yes, Junio, I think you were very right to > complain about that one. > > How does this one feel?
I think this is very natural and I like it.
I did not complain but just said I was puzzled, but after thinking about this a bit I probably should have ;-).