Re: [PATCH 4/2] Fix parent rewriting in --early-output

From: Sven Verdoolaege <skimo@kotnet.org>
Date: Nov 13, 2007, 07:53 UTC
Message-ID: <20071113075341.GN2261MdfPADPa@greensroom.kotnet.org>
In-Reply-To: <alpine.LFD.0.9999.0711122309270.2786@woody.linux-foundation.org>

On Mon, Nov 12, 2007 at 11:16:08PM -0800, Linus Torvalds wrote:

Show 11 quoted lines

> On Mon, 12 Nov 2007, Linus Torvalds wrote:
> > 
> > I think the real problem is that "TREECHANGE" has the wrong polarity. It 
> > should default to always being set, and then we could actively clear it 
> > when we do the work to say "it's the same tree". Instead, we default it to 
> > being the same (which triggers parent rewriting), and only later may we 
> > notice that it wasn't the same.
> 
> So, maybe the proper solution is to say "commits are assumed to be 
> different to their parents, but we have an explicit bit saying TREESAME 
> when we find them to be the same".

FWIW, I like it.

I had basically the same patch in my git-rewrite-commits series (except that I called it "PRUNED" instead of "TREESAME"), but I don't think I even sent it to the list, because I was told there was no use.

skimo