git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] create_ref_entry(): move check_refname_format() call to callers

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 30, 2012, 06:15 UTC
Message-ID
<7v1un5iw3t.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20120429115831.GC24254@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 5 quoted lines
> On Sun, Apr 29, 2012 at 08:18:08AM +0200, mhagger@alum.mit.edu wrote:
> ...
> It seems like the create_ref_entry code paths should _always_ just be
> issuing warnings, as they are about reading existing refs, no? The die()
> side should only come when we are writing refs.
That matches my observation.  Michael, are we missing something?
Previous: Jeff KingNext: Michael Haggerty
Message 3 of 8 in “create_ref_entry(): move check_refname_format() call to callers”
  1. create_ref_entry(): move check_refname_format() call to callersmhagger@alum.mit.edu, Apr 29, 2012
  2. Jeff KingApr 29, 2012
  3. Junio C HamanoApr 30, 2012
  4. Michael HaggertyApr 30, 2012
  5. Junio C HamanoApr 30, 2012
  6. Michael HaggertyApr 30, 2012
  7. Junio C HamanoApr 30, 2012
  8. Michael HaggertyMay 2, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.