From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 30 Apr 2012 06:15:18 GMT
Subject: Re: [PATCH] create_ref_entry(): move check_refname_format() call to callers
Message-ID: <7v1un5iw3t.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120429115831.GC24254@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Sun, Apr 29, 2012 at 08:18:08AM +0200, mhagger@alum.mit.edu wrote:
> ...
> It seems like the create_ref_entry code paths should _always_ just be
> issuing warnings, as they are about reading existing refs, no? The die()
> side should only come when we are writing refs.

That matches my observation.  Michael, are we missing something?