git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] create_ref_entry(): move check_refname_format() call to callers

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 30, 2012, 21:11 UTC
Message-ID
<7vsjfkexh1.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4F9EF60D.8030301@alum.mit.edu>
Michael Haggerty <mhagger@alum.mit.edu> writes:
Show 5 quoted lines
> For example, have all of the following code paths been audited to make
> sure that they cannot introduce class (3) refnames into a repository
> (including via symbolic refs with class (3) targets) even in the face
> of a malicious remote?  Can we (and do we want to) rely on this level
> of vigilance being sustained in the future?

Auditing is one thing, but perhaps the right solution to that issue is to refactor the existing code so that we have only a handful (preferrably one) API entry point that is used to create a new ref (not to be confused with create_ref_entry(), which is not necessarily about creating a ref)?

The UI layer may place additional restrictions to the source data used to eventually lead to a ref creation (e.g. your updated "git branch" may forbid you to create a branch with the name of an existing tag, perhaps), but after passing its check, the API to create a new ref will do mandatory "check-ref-format" check.

Previous: Michael HaggertyNext: Michael Haggerty
Message 7 of 8 in “create_ref_entry(): move check_refname_format() call to callers”
  1. create_ref_entry(): move check_refname_format() call to callersmhagger@alum.mit.edu, Apr 29, 2012
  2. Jeff KingApr 29, 2012
  3. Junio C HamanoApr 30, 2012
  4. Michael HaggertyApr 30, 2012
  5. Junio C HamanoApr 30, 2012
  6. Michael HaggertyApr 30, 2012
  7. Junio C HamanoApr 30, 2012
  8. Michael HaggertyMay 2, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.