Re: [PATCH] send-email: add proper default sender

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 13, 2012, 00:55 UTC
Message-ID: <7v1ufygw3y.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20121113000637.GI10531@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 11 quoted lines

> On Mon, Nov 12, 2012 at 07:02:17PM -0500, Jeff King wrote:
>
>> The one distinction that would make sense to me is pausing to ask when
>> we use "implicit" methods to look up the ident, like concatenating the
>> username with the hostname to get the email.
>
> By the way, I suspect this is the answer to "what do people type for
> this prompt". It is probably more about a safety on bad ident than it is
> about people routinely updating the information. I actually think it
> would make more sense to drop the prompt entirely and just die when the
> user has not given us a usable ident.

Yeah, I agree with pretty much everything you said in this thread (including that environment and config are equally likely to reflect user's wish and it does not make much sense to treat environment as more suspicious).

> But maybe people who do one-off format-patches would rather type
> their name in a prompt than set an environment variable and re-run
> the program.

s/one-off format-patches/one-off send-email/. I think dying will force them to configure their names once (so that later invocations do not have to stop) while prompting will force them to type their names every time, so the current behaviour is probably a false economy. As long as we caution users in the release notes, it probably is OK to change the command to die.