Re: [PATCH] send-email: add proper default sender
- From
Jeff King <peff@peff.net>
- Date
- Nov 13, 2012, 00:06 UTC
- Message-ID
- <20121113000637.GI10531@sigill.intra.peff.net>
- In-Reply-To
- <20121113000217.GH10531@sigill.intra.peff.net>
On Mon, Nov 12, 2012 at 07:02:17PM -0500, Jeff King wrote:
> The one distinction that would make sense to me is pausing to ask when > we use "implicit" methods to look up the ident, like concatenating the > username with the hostname to get the email.
By the way, I suspect this is the answer to "what do people type for this prompt". It is probably more about a safety on bad ident than it is about people routinely updating the information. I actually think it would make more sense to drop the prompt entirely and just die when the user has not given us a usable ident. But maybe people who do one-off format-patches would rather type their name in a prompt than set an environment variable and re-run the program.
-Peff