Re: [PATCHv2 8/8] send-email: do not prompt for explicit repo ident

From: Jeff King <peff@peff.net>
Date: Nov 15, 2012, 11:13 UTC
Message-ID: <20121115111334.GA1879@sigill.intra.peff.net>
In-Reply-To: <20121115104345.GA32465@sigill.intra.peff.net>

On Thu, Nov 15, 2012 at 02:43:58AM -0800, Jeff King wrote:

Show 16 quoted lines

> > And doesn't have any of the following:
> > 
> >  * configured user.name/user.email
> >  * specified $EMAIL
> >  * configured sendemail.from
> >  * specified --from argument
> > 
> > Very unlikely.
> 
> That is certainly the opinion you have stated already. I'm not sure I
> agree. Linus, for example, was an advocate of such a configuration early
> on in git's history. I don't think he still runs that way, though.
> 
> > And then, what would be the consequences of not receiving this prompt?
> 
> An email would be sent with the generated identity.

I suspect you did not need me to answer that question, but were setting it up as a rhetorical trap to mention the final confirmation, which I failed to note in my response.

I think a much more compelling argument/commit message for your suggested patch would be:

  We currently prompt the user for the "From" address. This is an
  inconvenience in the common case that the user has configured their
  identity in the environment, but is meant as a safety check for when
  git falls back to an implicitly generated identity (which may or may
  not be valid).

  That safety check is not really necessary, though, as by default
  send-email will prompt the user for a final confirmation before
  sending out any message. The likelihood that a user has both bothered
  to turn off this default _and_ not configured any identity (nor
  checked that the automatic identity is valid) is rather low.

I could accept that line of reasoning. I see that this argument is buried deep in your commit message, but I will admit to not reading your 9-point list of conditions all that closely, as the first 7 points are, in my opinion, not relevant (and I had already read and disagreed with them in other messages).

-Peff