Re: [PATCH resend] Test cccmd in t9001-send-email.sh and fix two bugs
- From
Jay Soffian <jaysoffian@gmail.com>
- Date
- Jun 18, 2009, 12:49 UTC
- Message-ID
- <76718490906180549mb65dc17va513c294038470d2@mail.gmail.com>
- In-Reply-To
- <200906181211.39440.markus.heidelberg@web.de>
On Thu, Jun 18, 2009 at 6:11 AM, Markus Heidelberg<markus.heidelberg@web.de> wrote:
> Paolo Bonzini, 17.06.2009: >> The first bug is that the --suppress-cc option for `cccmd' was >> misspelled as `ccmd' in the code.
Good catch. That error has actually existed since --suppress-cc was introduced in 65648283. But nor did I (sheesh, aren't many eyes supposed to make all bugs shallow?) catch it in 3531e2703d.
Show 6 quoted lines
> Then I noticed that the documentation mentions ccbody, but the code uses > bodycc. > The author seemed to intend using bodycc, since it is also used in the > tests and the commit message (3531e2703d, send-email: --suppress-cc > improvements, 2009-02-15), but besides the documentation, ccbody is used > in the bash completion.
Wow, I'm pretty sure I intended bodycc. And I'm not even dyslexic.
Thanks,
j.