Re: [PATCH v2] Test cccmd in t9001-send-email.sh and fix some bugs

From: Markus Heidelberg <markus.heidelberg@web.de>
Date: Jun 19, 2009, 10:06 UTC
Message-ID: <200906191206.05286.markus.heidelberg@web.de>
In-Reply-To: <1245328292-25280-1-git-send-email-bonzini@gnu.org>

Paolo Bonzini, 18.06.2009:

> For another patch series I'm working on I needed some tests
> for the cc-cmd feature of git-send-email.

I think this is text for a cover-letter.

Show 10 quoted lines

> This patch adds 3 tests for the feature and for the possibility
> to specify --suppress-cc multiple times, and fixes two bugs.
> The first bug is that the --suppress-cc option for `cccmd' was
> misspelled as `ccmd' in the code.  The second bug, which is
> actually found only with my other series, is that the argument
> to the cccmd is never quoted, so the cccmd would fail with
> patch file names containing a space.
> 
> A third bug I fix (in the docs) is that the bodycc argument was
> actually spelled ccbody in the documentation and bash completion.

And these three unrelated bug fixes should rather go into three separate patches.

Show 11 quoted lines

> Signed-off-by: Paolo Bonzini <bonzini@gnu.org>
> Cc: Markus Heidelberg <markus.heidelberg@web.de>
> ---
>  Documentation/git-send-email.txt       |    4 +-
>  contrib/completion/git-completion.bash |    2 +-
>  git-send-email.perl                    |    4 +-
>  t/t9001-send-email.sh                  |   80 ++++++++++++++++++++++++++++++--
>  4 files changed, 80 insertions(+), 10 deletions(-)
> 
> 	Thanks Markus for noticing my erroneous change and
> 	the inconsistency in the docs.

This normally goes directly under --- I didn't notice it before the second look.