Re: [PATCH resend] Test cccmd in t9001-send-email.sh and fix two bugs
- From
Markus Heidelberg <markus.heidelberg@web.de>
- Date
- Jun 18, 2009, 10:11 UTC
- Message-ID
- <200906181211.39440.markus.heidelberg@web.de>
- In-Reply-To
- <1245223062-27132-1-git-send-email-bonzini@gnu.org>
Paolo Bonzini, 17.06.2009:
> The first bug is that the --suppress-cc option for `cccmd' was > misspelled as `ccmd' in the code.
Show 7 quoted lines
> +++ b/git-send-email.perl
> @@ -334,7 +334,7 @@ if (@suppress_cc) {
> }
>
> if ($suppress_cc{'all'}) {
> - foreach my $entry (qw (ccmd cc author self sob body bodycc)) {
> + foreach my $entry (qw (cccmd cc author self sob body bodyccc)) {Additionally you incorrectly changed bodycc to bodyccc.
Then I noticed that the documentation mentions ccbody, but the code uses bodycc. The author seemed to intend using bodycc, since it is also used in the tests and the commit message (3531e2703d, send-email: --suppress-cc improvements, 2009-02-15), but besides the documentation, ccbody is used in the bash completion.
> $suppress_cc{$entry} = 1;
> }
> delete $suppress_cc{'all'};