Re: orthogonal cases of log --date option

From: Jay Soffian <jaysoffian@gmail.com>
Date: Mar 6, 2009, 06:58 UTC
Message-ID: <76718490903052258j277fa8e9g963deae1c3264a22@mail.gmail.com>
In-Reply-To: <7vmybzw3el.fsf@gitster.siamese.dyndns.org>

On Fri, Mar 6, 2009 at 1:50 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 12 quoted lines

> Jeff King <peff@peff.net> writes:
>
>> Because from the user's perspective --foo={bar,baz,bleep} is about
>> selecting exactly one of {bar,baz,bleep}.
>
> I do not feel very strongly about this either way, and without any prior
> end user "Huh?" input, I would probably have argued like you myself, but
> I saw the original message from Miles about giving more than one --date
> and getting perplexed to see that it did not work, so...
>
> I am not likely to use --tz=Indian/Christmas myself; GMT and local might
> however be useful in some situations, though.

So I don't mind picking this up, but I'd like some guidance. There are two issues:

1) The CLI. You and Jeff don't seem to have an agreement here, but
frankly, this is the easy part.

2) The internal implementation. Your implementation (enum -> bitfield)
is clever, but Jeff seems to prefer what I suggested (going to a
struct). The latter is quite a bit more work.

If we only care about fixing the original issue, I'll just pickup your patch, make sure it compiles, and add some tests. I certainly don't want to do more work than is needed, unless there's a good reason to do so.

j.