Re: orthogonal cases of log --date option
- From
Jeff King <peff@peff.net>
- Date
- Mar 6, 2009, 12:10 UTC
- Message-ID
- <20090306121058.GB3437@sigill.intra.peff.net>
- In-Reply-To
- <76718490903052258j277fa8e9g963deae1c3264a22@mail.gmail.com>
On Fri, Mar 06, 2009 at 01:58:36AM -0500, Jay Soffian wrote:
Show 6 quoted lines
> 1) The CLI. You and Jeff don't seem to have an agreement here, but > frankly, this is the easy part. > > 2) The internal implementation. Your implementation (enum -> bitfield) > is clever, but Jeff seems to prefer what I suggested (going to a > struct). The latter is quite a bit more work.
My argument for (2), btw, is that the code is easier to read and more maintainable if it follows the structure of the CLI. But I don't think it's as important as getting the CLI right.
-Peff