Re: [PATCH] Fix t9101 test failure caused by Subversion "auto-props"
On Nov 16, 2007, at 2:25 PM, Wincent Colaiuta wrote:
Show 37 quoted lines
> If a user has an "auto-prop" in his/her ~/.subversion/config file for
> automatically setting the svn:keyword Id property on all ".c" files
> (a reasonably common configuration in the Subversion world) then one
> of the "svn propset" operations in the very first test would become a
> no-op, which in turn would make the next commit a no-op.
>
> This then caused the 25th test ('test propget') to fail because it
> expects a certain number of commits to have taken place but the actual
> number of commits was off by one.
>
> Björn Steinbrink identified the "auto-prop" feature as the cause
> of the failure. This patch avoids it by passing the "--no-auto-prop"
> flag to "svn import" when setting up the test repository, thus
> ensuring
> that the "svn propset" operation is no longer a no-op, regardless
> of the
> users' settings in their config.
>
> Signed-off-by: Wincent Colaiuta <win@wincent.com>
> ---
> t/t9101-git-svn-props.sh | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/t/t9101-git-svn-props.sh b/t/t9101-git-svn-props.sh
> index 3c83127..d7a7047 100755
> --- a/t/t9101-git-svn-props.sh
> +++ b/t/t9101-git-svn-props.sh
> @@ -48,7 +48,7 @@ EOF
> printf "\r\n" > empty_crlf
> a_empty_crlf=`git-hash-object -w empty_crlf`
>
> - svn import -m 'import for git-svn' . "$svnrepo" >/dev/null
> + svn import --no-auto-props -m 'import for git-svn' .
> "$svnrepo" >/dev/null
> cd ..
>
> rm -rf importGreat, thank you for tackling this issue. It wasn't easy to find.
--
Benoit Sigoure aka Tsuna
EPITA Research and Development Laboratory