git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix t9101 test failure caused by Subversion "auto-props"

From
Benoit Sigoure <tsuna@lrde.epita.fr>
Date
Nov 16, 2007, 17:56 UTC
Message-ID
<75D25F7C-EAB4-49ED-80FF-2BC535915585@lrde.epita.fr>
In-Reply-To
<2F7DFDC9-D4E2-42D0-9E48-E51E7905FF42@wincent.com>
On Nov 16, 2007, at 2:25 PM, Wincent Colaiuta wrote:
Show 37 quoted lines
> If a user has an "auto-prop" in his/her ~/.subversion/config file for
> automatically setting the svn:keyword Id property on all ".c" files
> (a reasonably common configuration in the Subversion world) then one
> of the "svn propset" operations in the very first test would become a
> no-op, which in turn would make the next commit a no-op.
>
> This then caused the 25th test ('test propget') to fail because it
> expects a certain number of commits to have taken place but the actual
> number of commits was off by one.
>
> Björn Steinbrink identified the "auto-prop" feature as the cause
> of the failure. This patch avoids it by passing the "--no-auto-prop"
> flag to "svn import" when setting up the test repository, thus  
> ensuring
> that the "svn propset" operation is no longer a no-op, regardless  
> of the
> users' settings in their config.
>
> Signed-off-by: Wincent Colaiuta <win@wincent.com>
> ---
>  t/t9101-git-svn-props.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/t/t9101-git-svn-props.sh b/t/t9101-git-svn-props.sh
> index 3c83127..d7a7047 100755
> --- a/t/t9101-git-svn-props.sh
> +++ b/t/t9101-git-svn-props.sh
> @@ -48,7 +48,7 @@ EOF
>         printf "\r\n" > empty_crlf
>         a_empty_crlf=`git-hash-object -w empty_crlf`
>
> -       svn import -m 'import for git-svn' . "$svnrepo" >/dev/null
> +       svn import --no-auto-props -m 'import for git-svn' .  
> "$svnrepo" >/dev/null
>  cd ..
>
>  rm -rf import
Great, thank you for tackling this issue.  It wasn't easy to find.
-- 
Benoit Sigoure aka Tsuna
EPITA Research and Development Laboratory
Previous: Wincent ColaiutaNext: Junio C Hamano
Message 10 of 16 in “[BUG] t9101 (master) busted on Leopard”
  1. Wincent ColaiutaNov 15, 2007
  2. Brian GernhardtNov 15, 2007
  3. Wincent ColaiutaNov 15, 2007
  4. Benoit SigoureNov 15, 2007
  5. Wincent ColaiutaNov 15, 2007
  6. Wincent ColaiutaNov 16, 2007
  7. Björn SteinbrinkNov 16, 2007
  8. Wincent ColaiutaNov 16, 2007
  9. Fix t9101 test failure caused by Subversion "auto-props"Wincent Colaiuta, Nov 16, 2007
  10. Benoit SigoureNov 16, 2007
  11. Junio C HamanoNov 17, 2007
  12. Wincent ColaiutaNov 17, 2007
  13. Väinö JärveläNov 16, 2007
  14. Wincent ColaiutaNov 16, 2007
  15. Väinö JärveläNov 16, 2007
  16. Wincent ColaiutaNov 16, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.