Re: [PATCH 0/8] fsmonitor unused parameter cleanups

> Here are a few cleanups of the fsmonitor code to remove or annotate
> unused parameters (working towards my goal of making us compile clean
> with -Wunused-parameter). I think they should all be pretty
> non-controversial, but I'm cc-ing folks active in the area in case patch
> 2 steps on the toes of any unpublished works in progress.
> 
>    [1/8]: fsmonitor: prefer repo_git_path() to git_pathdup()
>    [2/8]: fsmonitor/win32: drop unused parameters
>    [3/8]: fsmonitor: mark some maybe-unused parameters
>    [4/8]: fsmonitor/win32: mark unused parameter in fsm_os__incompatible()
>    [5/8]: fsmonitor: mark unused parameters in stub functions
>    [6/8]: fsmonitor/darwin: mark unused parameters in system callback
>    [7/8]: fsmonitor: mark unused hashmap callback parameters
>    [8/8]: run-command: mark unused parameters in start_bg_wait callbacks
> 
>   builtin/fsmonitor--daemon.c             | 10 ++++++----
>   compat/fsmonitor/fsm-health-darwin.c    |  8 ++++----
>   compat/fsmonitor/fsm-ipc-win32.c        |  2 +-
>   compat/fsmonitor/fsm-listen-darwin.c    |  4 ++--
>   compat/fsmonitor/fsm-listen-win32.c     | 24 ++++++++++--------------
>   compat/fsmonitor/fsm-path-utils-win32.c |  7 ++++---
>   compat/fsmonitor/fsm-settings-win32.c   |  2 +-
>   fsmonitor-ipc.c                         | 10 +++++-----
>   fsmonitor-settings.c                    |  3 ++-
>   t/helper/test-simple-ipc.c              |  3 ++-
>   10 files changed, 37 insertions(+), 36 deletions(-)
> 
> -Peff